add c++ executable for benchmarking libjetreconstruction #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-fila
force-pushed
the
c_jetreconstruction
branch
from
8711bf0 to
2c31b44
Compare
m-fila
force-pushed
the
c_jetreconstruction
branch
from
c400617 to
2108be1
Compare
Collaborator
Author
|
This is now up to date with JuliaHEP/JetReconstruction.jl#88 supporting (immutable) PseudoJets |
graeme-a-stewart
requested changes
Jul 23, 2025
Owner
graeme-a-stewart
left a comment
graeme-a-stewart
left a comment
There was a problem hiding this comment.
Thanks @m-fila! Just a few suggestions about favouring things by algorithm, rather than by power (which we have deprecated).
Otherwise LGTM.
m-fila
force-pushed
the
c_jetreconstruction
branch
from
060a653 to
6e36fc7
Compare
graeme-a-stewart
force-pushed
the
c_jetreconstruction
branch
from
29e021b to
8c42c06
Compare
Owner
|
Rebased to merge in changes in |
Make -m and -n arguments consistent with other wrappers
graeme-a-stewart
approved these changes
Oct 17, 2025
Owner
|
This is still GTG @m-fila? It's not gone out of date with the work around ACAT? |
Collaborator
Author
|
Sorry, I missed the message. It was up to date, so all good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding benchmarks for ahead of time compiled JetReconstruction to a shared library JuliaHEP/JetReconstruction.jl#88.
For now this is just a C++ executable using the libjetreconstruction. It should be later merged together with fastjet benchmarking executable to avoid the duplications